summaryrefslogtreecommitdiff
authorTomas Cohen Arazi <tomascohen@theke.io>2016-05-24 17:28:44 (GMT)
committer Kyle M Hall <kyle@bywatersolutions.com>2016-06-10 16:49:43 (GMT)
commit7d4844e171b1319b90e7bd73510bd97c2acbf635 (patch) (side-by-side diff)
treeae6a6b638938504a7ea960bdcb3dfd2bd28e2ea5
parentaf59b669413539606f10652230e5f96d43337cb5 (diff)
Bug 16578: Fix wide character errors in opac-export.pl
This simple patch fixes wide character warning raised by opac-export.pl when 'MARC (Unicode/UTF-8)' and 'MARC (Unicode/UTF-8, Standard)' formats are chosen for downloading records. To test: - Have records indexed - Open your OPAC logs: $ tail -f /var/log/koha/kohadev/opac-error.log - Open the detail page in the opac for a record - Choose Save record > MARC (Unicode/UTF-8) => FAIL: opac-export.pl: Wide character in print at /home/vagrant/kohaclone/opac/opac-export.pl line 116., referer: http://localh... - Choose Save record > MARC (Unicode/UTF-8, Standard) => FAILE opac-export.pl: Wide character in print... - Apply the patch - Choose Save record > MARC (Unicode/UTF-8) => SUCCESS: No warnings raised. - Choose Save record > MARC (Unicode/UTF-8, Standard) => SUCCESS: No warnings raised. - Sign off :-D Followed test plan, works as expected. Signed-off-by: Marc VĂ©ron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Diffstat (more/less context) (ignore whitespace changes)
-rwxr-xr-xopac/opac-export.pl13
1 files changed, 8 insertions, 5 deletions
diff --git a/opac/opac-export.pl b/opac/opac-export.pl
index c4ab83a..3f32d1a 100755
--- a/opac/opac-export.pl
+++ b/opac/opac-export.pl
@@ -17,8 +17,7 @@
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
-use strict;
-use warnings;
+use Modern::Perl;
use C4::Record;
use C4::Auth;
@@ -107,11 +106,15 @@ else {
-charset => 'utf-8',
-attachment => "bib-$biblionumber.txt"
);
- }else{
+ } else {
+ binmode STDOUT, ':encoding(UTF-8)';
print $query->header(
-type => 'application/octet-stream',
- -charset=>'utf-8',
- -attachment=>"bib-$biblionumber.$format");
+ -charset => 'utf-8',
+ -attachment => "bib-$biblionumber.$format"
+ );
}
print $marc;
}
+
+1;